NEW: @W-17310939@: Add in our first AppExchange security rule... #173
Conversation
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
from
5abdae6 to
da80c93
Compare
| @@ -312,14 +312,14 @@ abstract class SharedConfigValueExtractor { | |||
| const extToLangMap: Map<string, Language> = new Map(); // To keep track if file extension shows up with more than one language | |||
| const fileExtensionsMap: Record<Language, string[]> = {... DEFAULT_FILE_EXTENSIONS}; // Start with copy | |||
| for (const language of Object.keys(fileExtensionsMap) as Language[]) { | |||
| const fileExts: string[] = makeUnique(fileExtensionsExtractor.extractArray(language, | |||
| const fileExts: string[] = makeUniqueCaseInsensitive(fileExtensionsExtractor.extractArray(language, | |||
There was a problem hiding this comment.
Since the AppExchange rules will need to add in more default file_extensions like .remoteSite... i'd prefer to not force the conversion of our defaults to all be lowercase since .remoteSite looks nicer than .remotesite and is what is all over the public documentation.
But things still work case insensitive as we expect. But it did require me to change the makeUnique function to be a makeUniqueCaseInsensitive routine instead.
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
from
da80c93 to
4e0660b
Compare
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <RemoteSiteSetting xmlns="http://soap.sforce.com/2006/04/metadata"> | ||
| <description>Used for Apex callout to mapping web service</description> | ||
| <disableProtocolSecurity>false</disableProtocolSecurity> | ||
| <isActive>true</isActive> | ||
| <url>https://www.maptestsite.net/mapping1</url> | ||
| </RemoteSiteSetting> |
There was a problem hiding this comment.
I got this example right from https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_remotesitesetting.htm
…e as a template for adding in more
stephen-carter-at-sf
force-pushed
the
sc/pmdAppExchange
branch
from
4e0660b to
cd5399b
Compare
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@salesforce/code-analyzer-pmd-engine", | |||
| "description": "Plugin package that adds 'pmd' and 'cpd' as engines into Salesforce Code Analyzer", | |||
| "version": "0.16.1", | |||
| "version": "0.16.2-SNAPSHOT", | |||
There was a problem hiding this comment.
Question: I know we typically only do new Minor Versions when Core changes, but does it make sense for us to add these new rules in a patch release?
There was a problem hiding this comment.
Yeah - I agree... now that we have a system in place to keep track of version numbers better... I don't think we need to keep all the engines in sync with their minor version anymore... So i'll make this 0.17.0-SNAPSHOT.
There was a problem hiding this comment.
Done.
... to serve as a template for adding in more